Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WIP): playground #45

Merged
merged 10 commits into from
Jun 18, 2024
Merged

feat(WIP): playground #45

merged 10 commits into from
Jun 18, 2024

Conversation

distractedm1nd
Copy link
Collaborator

@distractedm1nd distractedm1nd commented Jun 4, 2024

TODO:

  • Fix Notifications
  • Configuration section (URL, auth token)
  • Merge CORS fix in node
  • Styling improvements (i dont really like the modal yet, and seems too jumpy. might add transitions)
Screen.Recording.2024-06-04.at.4.00.00.PM.mov

@jcstein
Copy link
Member

jcstein commented Jun 17, 2024

I noticed while reviewing that if in medium and smaller screen sizes, the playground modal disappears. Though, the CI was green (edit: the linting just didn't run actually lol) until I resolved conflicts in index.tsx at 91d585c, but I think this is because of formatting.

Screenshot 2024-06-17 at 12 57 45 PM

@jcstein
Copy link
Member

jcstein commented Jun 17, 2024

Screenshot 2024-06-17 at 1 30 15 PM

f144f63

@jcstein jcstein self-requested a review June 17, 2024 17:35
Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. are all the things in todo list done? if not we can move unfinished tasks to new issues

@distractedm1nd
Copy link
Collaborator Author

Thanks for fixing the rest!! Looks good to me. The TODOs are complete

@distractedm1nd distractedm1nd merged commit da903c7 into main Jun 18, 2024
4 of 5 checks passed
@jcstein jcstein deleted the custom-playground branch June 18, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants